[ZF2 Beta 5] Form - ReCaptcha is broken

[cmple]

Hi,

ReCaptcha seems to load but its not functioning, I think it's related to the javascript error:

Source:




It looks like the "else if" statement is stripped out of the space => "elseif" thus throwing the error,
this happens in:
Zend\Form\View\Helper\Captcha\ReCaptcha
inside of the renderJsEvents($challengeId, $responseId) function,

but the weird part is, it looks fine in there:
} else if (el.attachEvent){

Any ideas why this is happening?

[cmple]

cmple wrote

It looks like the "else if" statement is stripped out of the space => "elseif" thus throwing the error,
this happens in:
Zend\Form\View\Helper\Captcha\ReCaptcha
inside of the renderJsEvents($challengeId, $responseId) function,

but the weird part is, it looks fine in there:
} else if (el.attachEvent){

Any ideas why this is happening?

Edit: oops, I was looking at a previous ZF2 version,
this is a new bug, javascript does not support "elseif" tag without a space => "else if"
here is the source:

[cmple]

PS.

Zend\Captcha\ReCaptcha has an incompatible $_messageTemplates variable thus returning null instead of an error message,
The variable must _not_ have an underscore: $messageTemplates

[weierophinney]

-- cmple <[hidden email]> wrote
(on Friday, 13 July 2012, 09:50 AM -0700):

>
> cmple wrote
> >
> > It looks like the "else if" statement is stripped out of the space =>
> > "elseif" thus throwing the error,
> > this happens in:
> > Zend\Form\View\Helper\Captcha\ReCaptcha
> > inside of the renderJsEvents($challengeId, $responseId) function,
> >
> > but the weird part is, it looks fine in there:
> > } *else if* (el.attachEvent){
> >
> > Any ideas why this is happening?
> >
>
> Edit: oops, I was looking at a previous ZF2 version,
> this is a new bug, javascript does not support "elseif" tag without a space
> => "else if"
> here is the source:
> http://zend-framework-community.634137.n4.nabble.com/file/n4655746/screenshot-8.jpg 

I've submitted a pull request to fix this:

    https://github.com/zendframework/zf2/pull/1882


--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc

--
List: [hidden email]
Info: http://framework.zend.com/archives
Unsubscribe: [hidden email]

[cmple]

weierophinney wrote

-- cmple <[hidden email]> wrote
(on Friday, 13 July 2012, 09:50 AM -0700):
>
> cmple wrote
> >
> > It looks like the "else if" statement is stripped out of the space =>
> > "elseif" thus throwing the error,
> > this happens in:
> > Zend\Form\View\Helper\Captcha\ReCaptcha
> > inside of the renderJsEvents($challengeId, $responseId) function,
> >
> > but the weird part is, it looks fine in there:
> > } *else if* (el.attachEvent){
> >
> > Any ideas why this is happening?
> >
>
> Edit: oops, I was looking at a previous ZF2 version,
> this is a new bug, javascript does not support "elseif" tag without a space
> => "else if"
> here is the source:
> http://zend-framework-community.634137.n4.nabble.com/file/n4655746/screenshot-8.jpg 

I've submitted a pull request to fix this:

    https://github.com/zendframework/zf2/pull/1882


--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc

--
List: [hidden email]
Info: http://framework.zend.com/archives
Unsubscribe: [hidden email]

Thanks Matthew!

Did you have a chance to look at Zend\Captcha\ReCaptcha's  $_messageTemplates variable?

[weierophinney]

-- cmple <[hidden email]> wrote
(on Friday, 13 July 2012, 11:59 AM -0700):

> weierophinney wrote
> > -- cmple &lt;roman.vidyayev@&gt; wrote
> > (on Friday, 13 July 2012, 09:50 AM -0700):
> > > cmple wrote
> > > >
> > > > It looks like the "else if" statement is stripped out of the space =>
> > > > "elseif" thus throwing the error,
> > > > this happens in:
> > > > Zend\Form\View\Helper\Captcha\ReCaptcha
> > > > inside of the renderJsEvents($challengeId, $responseId) function,
> > > >
> > > > but the weird part is, it looks fine in there:
> > > > } *else if* (el.attachEvent){
> > > >
> > > > Any ideas why this is happening?
> > > >
> > >
> > > Edit: oops, I was looking at a previous ZF2 version,
> > > this is a new bug, javascript does not support "elseif" tag without a
> > > space
> > > => "else if"
> > > here is the source:
> > > http://zend-framework-community.634137.n4.nabble.com/file/n4655746/screenshot-8.jpg 
> >
> > I've submitted a pull request to fix this:
> >
> >     https://github.com/zendframework/zf2/pull/1882
>
> Thanks Matthew!
>
> Did you have a chance to look at Zend\Captcha\ReCaptcha's
> $_messageTemplates variable?

Nope -- wasn't aware of the issue -- I'll take care of that too.

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc

--
List: [hidden email]
Info: http://framework.zend.com/archives
Unsubscribe: [hidden email]

[cmple]

Matthew,

ReCaptcha is now throwing the following error:
Fatal error: Class 'Zend\Service\ReCaptcha\ReCaptcha' not found in /***/vendor/ZF2/library/Zend/Captcha/ReCaptcha.php on line 129

Any thoughts on that?

Thanks!!
Roman

[richard]

cmple wrote

Matthew,

ReCaptcha is now throwing the following error:
Fatal error: Class 'Zend\Service\ReCaptcha\ReCaptcha' not found in /***/vendor/ZF2/library/Zend/Captcha/ReCaptcha.php on line 129

Any thoughts on that?

Thanks!!
Roman

Zend\Service\ReCaptcha\ReCaptcha is Zend\Captcha\ReCaptcha in master currently

[cmple]

richard wrote

cmple wrote

Matthew,

ReCaptcha is now throwing the following error:
Fatal error: Class 'Zend\Service\ReCaptcha\ReCaptcha' not found in /***/vendor/ZF2/library/Zend/Captcha/ReCaptcha.php on line 129

Any thoughts on that?

Thanks!!
Roman

Zend\Service\ReCaptcha\ReCaptcha is Zend\Captcha\ReCaptcha in master currently

Richard,
I can still see "Zend\Captcha\ReCaptcha" requiring the missing "Zend\Service\ReCaptcha\ReCaptcha" here:
https://github.com/zendframework/zf2/blob/master/library/Zend/Captcha/ReCaptcha.php#L15

Thanks!

[weierophinney]

-- cmple <[hidden email]> wrote
(on Wednesday, 25 July 2012, 08:35 AM -0700):
> ReCaptcha is now throwing the following error:
> Fatal error: Class 'Zend\Service\ReCaptcha\ReCaptcha' not found in
> /***/vendor/ZF2/library/Zend/Captcha/ReCaptcha.php on line 129
>
> Any thoughts on that?

Yes. :)

We moved all the service classes into their own repositories late last
week, and are still in the process of setting up the composer packages
for them. Should be sorted later today.

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc

--
List: [hidden email]
Info: http://framework.zend.com/archives
Unsubscribe: [hidden email]