ZF-12047

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

ZF-12047

Marc Bennewitz (private)
Hi all,

in base of ZF-12047 I created a patch renaming two options of
Zend_Cache_Backend_File:
hashed_directory_umask -> hashed_directory_perm
cache_file_umask -> cache_file_perm

The old options still presents but triggers a E_USER_DEPRECATED error.

If that's the way to go I commit the patch and resolve the issue.

Best regards
Marc
Reply | Threaded
Open this post in threaded view
|

Re: ZF-12047

weierophinney
Administrator
-- Marc Bennewitz <[hidden email]> wrote
(on Saturday, 10 March 2012, 12:04 PM +0100):
> in base of ZF-12047 I created a patch renaming two options of
> Zend_Cache_Backend_File:
> hashed_directory_umask -> hashed_directory_perm
> cache_file_umask -> cache_file_perm
>
> The old options still presents but triggers a E_USER_DEPRECATED error.
>
> If that's the way to go I commit the patch and resolve the issue.

Go ahead, however:

* Do it only on trunk (this should go into 1.12, not 1.11.12)
* Make a note in the README.txt file about the BC break, and how to fix
  it in userland code.

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
Reply | Threaded
Open this post in threaded view
|

Re: ZF-12047

till-2
On Mon, Mar 12, 2012 at 5:04 PM, Matthew Weier O'Phinney
<[hidden email]> wrote:

> -- Marc Bennewitz <[hidden email]> wrote
> (on Saturday, 10 March 2012, 12:04 PM +0100):
>> in base of ZF-12047 I created a patch renaming two options of
>> Zend_Cache_Backend_File:
>> hashed_directory_umask -> hashed_directory_perm
>> cache_file_umask -> cache_file_perm
>>
>> The old options still presents but triggers a E_USER_DEPRECATED error.
>>
>> If that's the way to go I commit the patch and resolve the issue.
>
> Go ahead, however:
>
> * Do it only on trunk (this should go into 1.12, not 1.11.12)
> * Make a note in the README.txt file about the BC break, and how to fix
>  it in userland code.

Shouldn't we avoid that?

Especially so late in the cycle?

Till
Reply | Threaded
Open this post in threaded view
|

Re: ZF-12047

weierophinney
Administrator
-- till <[hidden email]> wrote
(on Monday, 12 March 2012, 05:52 PM +0100):

> On Mon, Mar 12, 2012 at 5:04 PM, Matthew Weier O'Phinney
> <[hidden email]> wrote:
> > -- Marc Bennewitz <[hidden email]> wrote
> > (on Saturday, 10 March 2012, 12:04 PM +0100):
> >> in base of ZF-12047 I created a patch renaming two options of
> >> Zend_Cache_Backend_File:
> >> hashed_directory_umask -> hashed_directory_perm
> >> cache_file_umask -> cache_file_perm
> >>
> >> The old options still presents but triggers a E_USER_DEPRECATED error.
> >>
> >> If that's the way to go I commit the patch and resolve the issue.
> >
> > Go ahead, however:
> >
> > * Do it only on trunk (this should go into 1.12, not 1.11.12)
> > * Make a note in the README.txt file about the BC break, and how to fix
> >  it in userland code.
>
> Shouldn't we avoid that?
>
> Especially so late in the cycle?

If it's fixing a long-standing issue, I'd rather have it fixed for the
last minor release than not.

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
Reply | Threaded
Open this post in threaded view
|

Re: ZF-12047

till-2
On Mon, Mar 12, 2012 at 6:25 PM, Matthew Weier O'Phinney
<[hidden email]> wrote:

> -- till <[hidden email]> wrote
> (on Monday, 12 March 2012, 05:52 PM +0100):
>> On Mon, Mar 12, 2012 at 5:04 PM, Matthew Weier O'Phinney
>> <[hidden email]> wrote:
>> > -- Marc Bennewitz <[hidden email]> wrote
>> > (on Saturday, 10 March 2012, 12:04 PM +0100):
>> >> in base of ZF-12047 I created a patch renaming two options of
>> >> Zend_Cache_Backend_File:
>> >> hashed_directory_umask -> hashed_directory_perm
>> >> cache_file_umask -> cache_file_perm
>> >>
>> >> The old options still presents but triggers a E_USER_DEPRECATED error.
>> >>
>> >> If that's the way to go I commit the patch and resolve the issue.
>> >
>> > Go ahead, however:
>> >
>> > * Do it only on trunk (this should go into 1.12, not 1.11.12)
>> > * Make a note in the README.txt file about the BC break, and how to fix
>> >  it in userland code.
>>
>> Shouldn't we avoid that?
>>
>> Especially so late in the cycle?
>
> If it's fixing a long-standing issue, I'd rather have it fixed for the
> last minor release than not.

I think it depends. If both will continue to work, then it's not a BC break.

Per se, I don't mind a fix, but E_USER_DEPRECATED is annoying.

Till
Reply | Threaded
Open this post in threaded view
|

Re: ZF-12047

Marc Bennewitz (private)
In reply to this post by weierophinney
Matthew,

thanks for the explanation.

It simply renames two options because the old were wrong named and makes
it unclear how to use it.
Because the old name still exists it's not a "hard" bc break but it
triggers an E_USER_DEPRECATED error and should go into the migration guide.

damn: E_USER_DEPRECATED is PHP 5.3 :( -> than I trigger an E_USER_NOTICE

On 12.03.2012 18:25, Matthew Weier O'Phinney wrote:

> -- till <[hidden email]> wrote
> (on Monday, 12 March 2012, 05:52 PM +0100):
>> On Mon, Mar 12, 2012 at 5:04 PM, Matthew Weier O'Phinney
>> <[hidden email]> wrote:
>>> -- Marc Bennewitz <[hidden email]> wrote
>>> (on Saturday, 10 March 2012, 12:04 PM +0100):
>>>> in base of ZF-12047 I created a patch renaming two options of
>>>> Zend_Cache_Backend_File:
>>>> hashed_directory_umask -> hashed_directory_perm
>>>> cache_file_umask -> cache_file_perm
>>>>
>>>> The old options still presents but triggers a E_USER_DEPRECATED error.
>>>>
>>>> If that's the way to go I commit the patch and resolve the issue.
>>> Go ahead, however:
>>>
>>> * Do it only on trunk (this should go into 1.12, not 1.11.12)
>>> * Make a note in the README.txt file about the BC break, and how to fix
>>>  it in userland code.
>> Shouldn't we avoid that?
>>
>> Especially so late in the cycle?
> If it's fixing a long-standing issue, I'd rather have it fixed for the
> last minor release than not.
>
Reply | Threaded
Open this post in threaded view
|

Re: ZF-12047

Marc Bennewitz (private)
done

On 12.03.2012 21:57, Marc Bennewitz wrote:

> Matthew,
>
> thanks for the explanation.
>
> It simply renames two options because the old were wrong named and makes
> it unclear how to use it.
> Because the old name still exists it's not a "hard" bc break but it
> triggers an E_USER_DEPRECATED error and should go into the migration guide.
>
> damn: E_USER_DEPRECATED is PHP 5.3 :( -> than I trigger an E_USER_NOTICE
>
> On 12.03.2012 18:25, Matthew Weier O'Phinney wrote:
>> -- till <[hidden email]> wrote
>> (on Monday, 12 March 2012, 05:52 PM +0100):
>>> On Mon, Mar 12, 2012 at 5:04 PM, Matthew Weier O'Phinney
>>> <[hidden email]> wrote:
>>>> -- Marc Bennewitz <[hidden email]> wrote
>>>> (on Saturday, 10 March 2012, 12:04 PM +0100):
>>>>> in base of ZF-12047 I created a patch renaming two options of
>>>>> Zend_Cache_Backend_File:
>>>>> hashed_directory_umask -> hashed_directory_perm
>>>>> cache_file_umask -> cache_file_perm
>>>>>
>>>>> The old options still presents but triggers a E_USER_DEPRECATED error.
>>>>>
>>>>> If that's the way to go I commit the patch and resolve the issue.
>>>> Go ahead, however:
>>>>
>>>> * Do it only on trunk (this should go into 1.12, not 1.11.12)
>>>> * Make a note in the README.txt file about the BC break, and how to fix
>>>>  it in userland code.
>>> Shouldn't we avoid that?
>>>
>>> Especially so late in the cycle?
>> If it's fixing a long-standing issue, I'd rather have it fixed for the
>> last minor release than not.
>>