Tagged 1.12.0rc1

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Tagged 1.12.0rc1

weierophinney
Administrator
Hey, all --

Per Rob Allen's request, I've:

 * Created a release-1.12 branch
 * Tagged release-1.12.0rc1

I'm building packages now, and we'll roll them out either over the
weekend or first thing on Monday. If you have fixes for 1.12, please run
them by Rob before merging to the 1.12 branch; at this time; we should
only be addressing critical bugfixes.

Thanks!

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
Reply | Threaded
Open this post in threaded view
|

Re: Tagged 1.12.0rc1

Sascha-Oliver Prolic
2012/6/15 Matthew Weier O'Phinney <[hidden email]>:

> Hey, all --
>
> Per Rob Allen's request, I've:
>
>  * Created a release-1.12 branch
>  * Tagged release-1.12.0rc1
>
> I'm building packages now, and we'll roll them out either over the
> weekend or first thing on Monday. If you have fixes for 1.12, please run
> them by Rob before merging to the 1.12 branch; at this time; we should
> only be addressing critical bugfixes.
>
> Thanks!
>
> --
> Matthew Weier O'Phinney
> Project Lead            | [hidden email]
> Zend Framework          | http://framework.zend.com/
> PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc

In Zend_File_ClassFileLocator the rewind() call in the constructor has
to be removed.

--
Sascha-Oliver Prolic
Reply | Threaded
Open this post in threaded view
|

Re: Tagged 1.12.0rc1

Martin Hujer
This post has NOT been accepted by the mailing list yet.
In reply to this post by weierophinney
Great!

What about some still failing tests? (I can see, that they are marked as "After1.12.0")
http://framework.zend.com/issues/browse/ZF-12201
http://framework.zend.com/issues/browse/ZF-12202
http://framework.zend.com/issues/browse/ZF-12281
http://framework.zend.com/issues/browse/ZF-12282

And more important one: http://framework.zend.com/issues/browse/ZF-12179 - this one may possibly lead to nonfunctional loading from phar on Windows

http://framework.zend.com/issues/browse/ZF-12228 - Windows Azure stuff is probably not working as it uses non existing files and classes

MH.
Reply | Threaded
Open this post in threaded view
|

RE: Tagged 1.12.0rc1

BullfrogBlues
In reply to this post by weierophinney





> Date: Fri, 15 Jun 2012 16:37:50 -0500

> From: [hidden email]
> To: [hidden email]
> Subject: [zf-contributors] Tagged 1.12.0rc1
>
> Hey, all --
>
> Per Rob Allen's request, I've:
>
> * Created a release-1.12 branch
> * Tagged release-1.12.0rc1
>
> I'm building packages now, and we'll roll them out either over the
> weekend or first thing on Monday. If you have fixes for 1.12, please run
> them by Rob before merging to the 1.12 branch; at this time; we should
> only be addressing critical bugfixes.
>
> Thanks!
>
> --
> Matthew Weier O'Phinney
> Project Lead | [hidden email]
> Zend Framework | http://framework.zend.com/
> PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc

Why does the constructor in Zend_Loader_StandardLoader auto register the Zend prefix? I asked about this with no success, here http://zend-framework-community.634137.n4.nabble.com/Zend-Loader-StandardAutoloader-constructor-amp-auto-registering-prefix-namespace-td4655243.html.

This is the constructor of the Standard autolaoder:

    public function __construct($options = null)
    {
        $this->registerPrefix('Zend', dirname(dirname(__FILE__)));

        $zfDir = dirname(dirname(dirname(__FILE__))) . '/Zend';
        if (file_exists($zfDir)) {
             $this->registerPrefix('Zend', $zfDir);
        }

        if (null !== $options) {
            $this->setOptions($options);
        }
    }
http://framework.zend.com/code/filedetails.php?repname=Zend+Framework&path=%2Ftags%2Frelease-1.12.0rc1%2Flibrary%2FZend%2FLoader%2FStandardAutoloader.php

dirname() is expensive. I'm using PHP5.3 so I can take advantage of __DIR__, which is why the zend prefix should not be auto registered. I will happily set the path manually in the bootstrap.

Also I can't understand at all why the zend prefix is registered, *then* checked to see if it exists? And then set it again? I don't understand this.

My suggestion is to move to the auto register functionality to an *opt-in* ease-of-use method. i.e. something like $a = new Zend_Loader_StandardAutoloader(); $a->autoRegisterZend();

Gerry
Reply | Threaded
Open this post in threaded view
|

Re: Tagged 1.12.0rc1

weierophinney
Administrator
In reply to this post by Sascha-Oliver Prolic
-- Sascha-Oliver Prolic <[hidden email]> wrote
(on Friday, 15 June 2012, 11:49 PM +0200):

> 2012/6/15 Matthew Weier O'Phinney <[hidden email]>:
> > Per Rob Allen's request, I've:
> >
> >  * Created a release-1.12 branch
> >  * Tagged release-1.12.0rc1
> >
> > I'm building packages now, and we'll roll them out either over the
> > weekend or first thing on Monday. If you have fixes for 1.12, please run
> > them by Rob before merging to the 1.12 branch; at this time; we should
> > only be addressing critical bugfixes.
>
> In Zend_File_ClassFileLocator the rewind() call in the constructor has
> to be removed.

Fixed no in trunk and the release-1.12 branch -- thanks!

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc