Quantcast

RewriteRouter moved to core as of Revision 876, please double check it

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

RewriteRouter moved to core as of Revision 876, please double check it

Jayson Minard (ZF)
RewriteRouter moved to core as of Revision 876, please double check it Please double check my move of RewriteRouter to core.  I moved tests, manual and the classes.  If you (anyone) can take a quick peak and confirm the move (a few more sets of eyes is always helpful), we’ll branch 0.1.5 and be done with the release.

--j
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: RewriteRouter moved to core as of Revision 876, please double check it

Dinh
Hi,

I have just checked out the respository and seen it there. I am going
to play with it.

Thanks

On 7/11/06, Jayson Minard <[hidden email]> wrote:
>
>  Please double check my move of RewriteRouter to core.  I moved tests,
> manual and the classes.  If you (anyone) can take a quick peak and confirm
> the move (a few more sets of eyes is always helpful), we'll branch 0.1.5 and
> be done with the release.
>
>  --j


--
Nobody in nowhere
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: RewriteRouter moved to core as of Revision 876, please double check it

Jayson Minard (ZF)
Thanks Dinh.

--j


On 7/10/06 7:14 PM, "Dinh" <[hidden email]> wrote:

> Hi,
>
> I have just checked out the respository and seen it there. I am going
> to play with it.
>
> Thanks
>
> On 7/11/06, Jayson Minard <[hidden email]> wrote:
>>
>>  Please double check my move of RewriteRouter to core.  I moved tests,
>> manual and the classes.  If you (anyone) can take a quick peak and confirm
>> the move (a few more sets of eyes is always helpful), we'll branch 0.1.5 and
>> be done with the release.
>>
>>  --j
>


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: RewriteRouter moved to core as of Revision 876, please double check it

TAKAGI Masahiro-3
In reply to this post by Jayson Minard (ZF)
Hi,

At Mon, 10 Jul 2006 17:25:03 -0700,
Jayson Minard wrote:
>
> Please double check my move of RewriteRouter to core.  I moved tests, manual
> and the classes.  If you (anyone) can take a quick peak and confirm the move
> (a few more sets of eyes is always helpful), we¹ll branch 0.1.5 and be done
> with the release.
>
I checked the manual and found a few problems.

1) The doc for "Zend_Controller_RewriteRouter" should be placed in the
   next of "Zend_Controller" rather than between "Zend_Pdf" and
   "Zend_Search".

2) In the "Default routes" section it says "... in the Getting Started
   chapter (paragraph 2.2.5)" but actually it is not "2.2.5" but
   "4.2.5" now.

The attached patch will fix them.

Regards,
--
TAKAGI Masahiro mailto:[hidden email]

Zend_Controller_RewriteRouter.diff.gz (936 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: RewriteRouter moved to core as of Revision 876, please double check it

Jayson Minard (ZF)
Patch has been applied.  Thanks!


On 7/10/06 7:32 PM, "TAKAGI Masahiro" <[hidden email]> wrote:

> Hi,
>
> At Mon, 10 Jul 2006 17:25:03 -0700,
> Jayson Minard wrote:
>>
>> Please double check my move of RewriteRouter to core.  I moved tests, manual
>> and the classes.  If you (anyone) can take a quick peak and confirm the move
>> (a few more sets of eyes is always helpful), we¹ll branch 0.1.5 and be done
>> with the release.
>>
> I checked the manual and found a few problems.
>
> 1) The doc for "Zend_Controller_RewriteRouter" should be placed in the
>    next of "Zend_Controller" rather than between "Zend_Pdf" and
>    "Zend_Search".
>
> 2) In the "Default routes" section it says "... in the Getting Started
>    chapter (paragraph 2.2.5)" but actually it is not "2.2.5" but
>    "4.2.5" now.
>
> The attached patch will fix them.
>
> Regards,


Loading...