PR-1403 / PHP-#43200

[Marc Bennewitz (private)]

Hi all,

Since PHP 5.3.9 a bug was fixed to make it possible to inherit a defined
method within interfaces and abstract classes.
(https://bugs.php.net/bug.php?id=43200)

Now I implemented such to specify a more detailed response
(https://github.com/zendframework/zf2/pull/1403/files#r919173)

Because of we support up to PHP 5.3.3 I commented the lines. So on later
releases (no longer supporting PHP < 5.3.9) it's simple to re-implement.

Is it ok to let the commented lines in or how to handle such things ?

Greetings
Marc

[Sascha-Oliver Prolic]

2012/6/7 Marc Bennewitz <[hidden email]>:

> Hi all,
>
> Since PHP 5.3.9 a bug was fixed to make it possible to inherit a defined
> method within interfaces and abstract classes.
> (https://bugs.php.net/bug.php?id=43200)
>
> Now I implemented such to specify a more detailed response
> (https://github.com/zendframework/zf2/pull/1403/files#r919173)
>
> Because of we support up to PHP 5.3.3 I commented the lines. So on later
> releases (no longer supporting PHP < 5.3.9) it's simple to re-implement.
>
> Is it ok to let the commented lines in or how to handle such things ?
>
> Greetings
> Marc
>

Please also mention, that as of PHP 5.3.9 up, the following of the php
manual is also no longer valid:

php.net/interface
"Note:

A class cannot implement two interfaces that share function names,
since it would cause ambiguity."

This is an important change as it was against oop concepts and me
personally, ran in some issues with that already, that where not
always easy to solve.

So raising php minimum version to at least 5.3.9 would be reasonable.

Best Regards

Sascha

--
Sascha-Oliver Prolic

[Sascha-Oliver Prolic]

2012/6/7 Marc Bennewitz <[hidden email]>:

> Hi all,
>
> Since PHP 5.3.9 a bug was fixed to make it possible to inherit a defined
> method within interfaces and abstract classes.
> (https://bugs.php.net/bug.php?id=43200)
>
> Now I implemented such to specify a more detailed response
> (https://github.com/zendframework/zf2/pull/1403/files#r919173)
>
> Because of we support up to PHP 5.3.3 I commented the lines. So on later
> releases (no longer supporting PHP < 5.3.9) it's simple to re-implement.
>
> Is it ok to let the commented lines in or how to handle such things ?
>
> Greetings
> Marc
>

Hi Marc, Hi all,

It's also possible to add a phpdoc comment like this:
"@method IterableInterface getIterator() return IterableInterface" in
class comment, but i don't know if that's wished.
Anyway it's reasonable for this case, if we get forced to stay on
5.3.3 as minimum version.

Best Regards

Sascha

--
Sascha-Oliver Prolic

[ralphschindler]

Is the driving factor here because you wanted a phpdoc comment for that
particular method?

I am failing to see what about this is so non-trivial as to warrant
bumping the minimum version of the framework up?

Also, it has been discussed and 5.4 will not be a minimum version for
ZF2 (there are too many factors involved in such a decision beyond PHP
feature set).

-ralph

On 6/7/12 2:32 PM, Marc Bennewitz wrote:

> Hi all,
>
> Since PHP 5.3.9 a bug was fixed to make it possible to inherit a defined
> method within interfaces and abstract classes.
> (https://bugs.php.net/bug.php?id=43200)
>
> Now I implemented such to specify a more detailed response
> (https://github.com/zendframework/zf2/pull/1403/files#r919173)
>
> Because of we support up to PHP 5.3.3 I commented the lines. So on later
> releases (no longer supporting PHP<  5.3.9) it's simple to re-implement.
>
> Is it ok to let the commented lines in or how to handle such things ?
>
> Greetings
> Marc
>

[weierophinney]

-- Sascha-Oliver Prolic <[hidden email]> wrote
(on Thursday, 07 June 2012, 10:17 PM +0200):

> 2012/6/7 Marc Bennewitz <[hidden email]>:
> > Since PHP 5.3.9 a bug was fixed to make it possible to inherit a defined
> > method within interfaces and abstract classes.
> > (https://bugs.php.net/bug.php?id=43200)
> >
> > Now I implemented such to specify a more detailed response
> > (https://github.com/zendframework/zf2/pull/1403/files#r919173)
> >
> > Because of we support up to PHP 5.3.3 I commented the lines. So on later
> > releases (no longer supporting PHP < 5.3.9) it's simple to re-implement.
> >
> > Is it ok to let the commented lines in or how to handle such things ?
>
> Please also mention, that as of PHP 5.3.9 up, the following of the php
> manual is also no longer valid:
>
> php.net/interface
> "Note:
>
> A class cannot implement two interfaces that share function names,
> since it would cause ambiguity."
>
> This is an important change as it was against oop concepts and me
> personally, ran in some issues with that already, that where not
> always easy to solve.
>
> So raising php minimum version to at least 5.3.9 would be reasonable.

No, it's not. We need to survey where various popular Linux distros with
LTS variants are, as well as popular hosting providers, in terms of the
PHP version we ship. While it would be nice to simply choose the PHP
version based on features/issues/etc., we need to be practical about
what PHP versions will be widely available

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc

[Marc Bennewitz (private)]

Hi Ralph,

First, I don't won't to restart discussion on minimum version for ZF2.

Yes, the driving factor on this example was to have a more specific
return type described within the phpdoc
but an additional (optional) argument would also be possible.

The question is about how to comment such situations to it clean what it
should and on future versions (e.g ZF3) such lines can simply be found.

Greetings
Marc

On 08.06.2012 05:22, Ralph Schindler wrote:

> Is the driving factor here because you wanted a phpdoc comment for
> that particular method?
>
> I am failing to see what about this is so non-trivial as to warrant
> bumping the minimum version of the framework up?
>
> Also, it has been discussed and 5.4 will not be a minimum version for
> ZF2 (there are too many factors involved in such a decision beyond PHP
> feature set).
>
> -ralph
>
> On 6/7/12 2:32 PM, Marc Bennewitz wrote:
>> Hi all,
>>
>> Since PHP 5.3.9 a bug was fixed to make it possible to inherit a defined
>> method within interfaces and abstract classes.
>> (https://bugs.php.net/bug.php?id=43200)
>>
>> Now I implemented such to specify a more detailed response
>> (https://github.com/zendframework/zf2/pull/1403/files#r919173)
>>
>> Because of we support up to PHP 5.3.3 I commented the lines. So on later
>> releases (no longer supporting PHP<  5.3.9) it's simple to re-implement.
>>
>> Is it ok to let the commented lines in or how to handle such things ?
>>
>> Greetings
>> Marc
>>
>
>

[BullfrogBlues]

> Date: Thu, 7 Jun 2012 22:22:38 -0500

> From: [hidden email]
> To: [hidden email]
> Subject: Re: [zf-contributors] PR-1403 / PHP-#43200
>
> Is the driving factor here because you wanted a phpdoc comment for that
> particular method?
>
> I am failing to see what about this is so non-trivial as to warrant
> bumping the minimum version of the framework up?
>
> Also, it has been discussed and 5.4 will not be a minimum version for
> ZF2 (there are too many factors involved in such a decision beyond PHP
> feature set).
>
> -ralph

Discussed, but never voted on. A vote would be fascinating.

http://framework.zend.com/wiki/pages/viewpage.action?pageId=46792838

[weierophinney]

-- Marc Bennewitz <[hidden email]> wrote
(on Saturday, 09 June 2012, 01:22 PM +0200):
> First, I don't won't to restart discussion on minimum version for ZF2.
>
> Yes, the driving factor on this example was to have a more specific
> return type described within the phpdoc
> but an additional (optional) argument would also be possible.
>
> The question is about how to comment such situations to it clean what it
> should and on future versions (e.g ZF3) such lines can simply be found.

Do it in the class-level docblock, and/or in the end-user documentation.

> On 08.06.2012 05:22, Ralph Schindler wrote:
> > Is the driving factor here because you wanted a phpdoc comment for
> > that particular method?
> >
> > I am failing to see what about this is so non-trivial as to warrant
> > bumping the minimum version of the framework up?
> >
> > Also, it has been discussed and 5.4 will not be a minimum version for
> > ZF2 (there are too many factors involved in such a decision beyond PHP
> > feature set).
> >
> > -ralph
> >
> > On 6/7/12 2:32 PM, Marc Bennewitz wrote:
> >> Hi all,
> >>
> >> Since PHP 5.3.9 a bug was fixed to make it possible to inherit a defined
> >> method within interfaces and abstract classes.
> >> (https://bugs.php.net/bug.php?id=43200)
> >>
> >> Now I implemented such to specify a more detailed response
> >> (https://github.com/zendframework/zf2/pull/1403/files#r919173)
> >>
> >> Because of we support up to PHP 5.3.3 I commented the lines. So on later
> >> releases (no longer supporting PHP<  5.3.9) it's simple to re-implement.
> >>
> >> Is it ok to let the commented lines in or how to handle such things ?
> >>
> >> Greetings
> >> Marc
> >>
> >
> >
>

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc