Hey, all --
As I've been creating unit tests for the new/refactored components
coming in, I've been doing some thinking in a few areas.
One area involves how to handle forwarding to another action.
Some of us had discussed passing back a boolean true from the action,
pre-, or postDispatch methods in order to indicate that another action
has been requested. I have a problem with this idea as there may be a
number of situations where a return value may be desired. Additionally,
I've been considering usage of a response object; using one would cause
some huge changes later.
So, something I considered: what if we create a flag in the request
object indicating 'dispatched'? Then, if it's not toggled on, we know
that the request in the object needs to be dispatched still; otherwise,
we know that the request has been processed.
Here's what I'm envisioning:
$request->setDispatched(false); // not yet dispatched
$request->setDispatched(true); // already dispatched, or skip
$request->isDispatched(); // has it been dispatched?
As a class skeleton:
interface Zend_Controller_Request_Interface
{
public function getControllerName();
public function setControllerName($value);
public function getActionName();
public function setActionName($value);
public function getParam($key);
public function setParam($key, $value);
public function getParams();
public function setParams($array);
public function setDispatched($flag);
public function isDispatched();
}
/**
* We can probably create the basic functionality in the
* abstract class for all of the methods; just doing the dispatched
* methods here
abstract class Zend_Controller_Request_Abstract implements Zend_Controller_Request_Interface
{
protected $_dispatched = false;
public function setDispatched($flag)
{
$this->_dispatched = $flag ? true : false;
}
public function isDispatched()
{
return $this->_dispatched;
}
}
Then, in Zend_Controller_Front::dispatch()'s dispatch loop:
do {
$request->setDispatched(true);
// notify plugins that a dispatch is about to occur
$this->_plugins->preDispatch($request);
// skip requested action if preDispatch() has reset it
if (!$request->isDispatched()) {
continue;
}
$response = $this->getDispatcher()->dispatch($request);
// notify plugins that the dispatch has finish
$this->_plugins->postDispatch($request);
} while (!$request->isDispatched());
Zend_Controller_Action::_forward() would look something like this then:
protected function _forward($controller, $action, $params = array())
{
$this->_request->setControllerName($controller);
$this->_request->setActionName($action);
$this->_request->setParams($params);
$this->_request->setDispatched(false);
}
Thoughts?
--
Matthew Weier O'Phinney
PHP Developer |
[hidden email]
Zend - The PHP Company |
http://www.zend.com/
Locked
