Code freeze for 2.2.2

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

Code freeze for 2.2.2

weierophinney
Administrator
Hey, all --

We've got only one PR left marked for 2.2.2, and I've asked the
Community Review team for review of that. At this point, I'd like
folks to test what's on current master against their applications, and
let me know ASAP if you notice anything that does not work.

I plan to tag and release no later than Wednesday.

Thanks everyone for the great patches this past month!

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

ThaDafinser
Hello,

application works fine with PHP 5.4.

Running the ZF2 testsuite seems to be a problem.
Notice: running the ZF2 testsuite the firsttime, so maybe it's something old
Enviroment: PHP 5.4 + WIN7

...........................................................  3422 / 17278 ( 19%)

...........................................................  3481 / 17278 ( 20%)

...........................................................  3540 / 17278 ( 20%)

PHP Fatal error:  Out of memory (allocated 510394368) (tried to allocate 3609722
88 bytes) in C:\Data\Zend\Apache2\htdocs\lisp_5.0.x\vendor\zendframework\zendfra
mework\library\Zend\Console\Adapter\AbstractAdapter.php on line 59
PHP Stack trace:
PHP   1. {main}() C:\Data\Zend\ZendServer\bin\PEAR\phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() C:\Data\Zend\ZendServer\bin\PEAR\phpunit
:46
PHP   3. PHPUnit_TextUI_Command->run() C:\Data\Zend\ZendServer\bin\PEAR\pear\PHP
Unit\TextUI\Command.php:129
PHP   4. PHPUnit_TextUI_TestRunner->doRun() C:\Data\Zend\ZendServer\bin\PEAR\pea
r\PHPUnit\TextUI\Command.php:176
PHP   5. PHPUnit_Framework_TestSuite->run() C:\Data\Zend\Apache2\htdocs\lisp_5.0
.x\vendor\phpunit\phpunit\PHPUnit\TextUI\TestRunner.php:349
PHP   6. PHPUnit_Framework_TestSuite->run() C:\Data\Zend\Apache2\htdocs\lisp_5.0
.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestSuite.php:705
PHP   7. PHPUnit_Framework_TestSuite->runTest() C:\Data\Zend\Apache2\htdocs\lisp
_5.0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestSuite.php:745
PHP   8. PHPUnit_Framework_TestCase->run() C:\Data\Zend\Apache2\htdocs\lisp_5.0.
x\vendor\phpunit\phpunit\PHPUnit\Framework\TestSuite.php:775
PHP   9. PHPUnit_Framework_TestResult->run() C:\Data\Zend\Apache2\htdocs\lisp_5.
0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestCase.php:776
PHP  10. PHPUnit_Framework_TestCase->runBare() C:\Data\Zend\Apache2\htdocs\lisp_
5.0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestResult.php:648
PHP  11. PHPUnit_Framework_TestCase->runTest() C:\Data\Zend\Apache2\htdocs\lisp_
5.0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestCase.php:831
PHP  12. ReflectionMethod->invokeArgs() C:\Data\Zend\Apache2\htdocs\lisp_5.0.x\v
endor\phpunit\phpunit\PHPUnit\Framework\TestCase.php:976
PHP  13. ZendTest\Console\Char\NumberTest->testCanReadNumberOnMultilign() C:\Dat
a\Zend\Apache2\htdocs\lisp_5.0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestCa
se.php:976
PHP  14. Zend\Console\Prompt\Number->show() C:\Data\Zend\Apache2\htdocs\lisp_5.0
.x\vendor\zendframework\zendframework\tests\ZendTest\Console\Prompt\NumberTest.p
hp:59
PHP  15. Zend\Console\Prompt\Line->show() C:\Data\Zend\Apache2\htdocs\lisp_5.0.x
\vendor\zendframework\zendframework\library\Zend\Console\Prompt\Number.php:83
PHP  16. Zend\Console\Adapter\AbstractAdapter->write() C:\Data\Zend\Apache2\htdo
cs\lisp_5.0.x\vendor\zendframework\zendframework\library\Zend\Console\Prompt\Lin
e.php:59



2013/7/22 Matthew Weier O'Phinney <[hidden email]>
Hey, all --

We've got only one PR left marked for 2.2.2, and I've asked the
Community Review team for review of that. At this point, I'd like
folks to test what's on current master against their applications, and
let me know ASAP if you notice anything that does not work.

I plan to tag and release no later than Wednesday.

Thanks everyone for the great patches this past month!

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc

Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

Marco Pivetta
@Martin you should probably use the utility `tests/run-tests.php` - all the suite at once is a lot of memory :)



On 24 July 2013 10:11, Martin Keckeis <[hidden email]> wrote:
Hello,

application works fine with PHP 5.4.

Running the ZF2 testsuite seems to be a problem.
Notice: running the ZF2 testsuite the firsttime, so maybe it's something old
Enviroment: PHP 5.4 + WIN7

...........................................................  3422 / 17278 ( 19%)

...........................................................  3481 / 17278 ( 20%)

...........................................................  3540 / 17278 ( 20%)

PHP Fatal error:  Out of memory (allocated 510394368) (tried to allocate 3609722
88 bytes) in C:\Data\Zend\Apache2\htdocs\lisp_5.0.x\vendor\zendframework\zendfra
mework\library\Zend\Console\Adapter\AbstractAdapter.php on line 59
PHP Stack trace:
PHP   1. {main}() C:\Data\Zend\ZendServer\bin\PEAR\phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() C:\Data\Zend\ZendServer\bin\PEAR\phpunit
:46
PHP   3. PHPUnit_TextUI_Command->run() C:\Data\Zend\ZendServer\bin\PEAR\pear\PHP
Unit\TextUI\Command.php:129
PHP   4. PHPUnit_TextUI_TestRunner->doRun() C:\Data\Zend\ZendServer\bin\PEAR\pea
r\PHPUnit\TextUI\Command.php:176
PHP   5. PHPUnit_Framework_TestSuite->run() C:\Data\Zend\Apache2\htdocs\lisp_5.0
.x\vendor\phpunit\phpunit\PHPUnit\TextUI\TestRunner.php:349
PHP   6. PHPUnit_Framework_TestSuite->run() C:\Data\Zend\Apache2\htdocs\lisp_5.0
.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestSuite.php:705
PHP   7. PHPUnit_Framework_TestSuite->runTest() C:\Data\Zend\Apache2\htdocs\lisp
_5.0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestSuite.php:745
PHP   8. PHPUnit_Framework_TestCase->run() C:\Data\Zend\Apache2\htdocs\lisp_5.0.
x\vendor\phpunit\phpunit\PHPUnit\Framework\TestSuite.php:775
PHP   9. PHPUnit_Framework_TestResult->run() C:\Data\Zend\Apache2\htdocs\lisp_5.
0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestCase.php:776
PHP  10. PHPUnit_Framework_TestCase->runBare() C:\Data\Zend\Apache2\htdocs\lisp_
5.0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestResult.php:648
PHP  11. PHPUnit_Framework_TestCase->runTest() C:\Data\Zend\Apache2\htdocs\lisp_
5.0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestCase.php:831
PHP  12. ReflectionMethod->invokeArgs() C:\Data\Zend\Apache2\htdocs\lisp_5.0.x\v
endor\phpunit\phpunit\PHPUnit\Framework\TestCase.php:976
PHP  13. ZendTest\Console\Char\NumberTest->testCanReadNumberOnMultilign() C:\Dat
a\Zend\Apache2\htdocs\lisp_5.0.x\vendor\phpunit\phpunit\PHPUnit\Framework\TestCa
se.php:976
PHP  14. Zend\Console\Prompt\Number->show() C:\Data\Zend\Apache2\htdocs\lisp_5.0
.x\vendor\zendframework\zendframework\tests\ZendTest\Console\Prompt\NumberTest.p
hp:59
PHP  15. Zend\Console\Prompt\Line->show() C:\Data\Zend\Apache2\htdocs\lisp_5.0.x
\vendor\zendframework\zendframework\library\Zend\Console\Prompt\Number.php:83
PHP  16. Zend\Console\Adapter\AbstractAdapter->write() C:\Data\Zend\Apache2\htdo
cs\lisp_5.0.x\vendor\zendframework\zendframework\library\Zend\Console\Prompt\Lin
e.php:59



2013/7/22 Matthew Weier O'Phinney <[hidden email]>
Hey, all --

We've got only one PR left marked for 2.2.2, and I've asked the
Community Review team for review of that. At this point, I'd like
folks to test what's on current master against their applications, and
let me know ASAP if you notice anything that does not work.

I plan to tag and release no later than Wednesday.

Thanks everyone for the great patches this past month!

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc


Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

Stefano Torresi
In reply to this post by weierophinney
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

ThaDafinser
Hello together,

@Marco thanks, yes with "run-tests.php" it work....

But there are others problem then so i stopped them for now...maybe i'll do a UnitTest compability day for windows....

All path tests for example are problematic due to slash/backslash and so on....



2013/7/24 Stefano Torresi <[hidden email]>
It's not framework related but rather about the test suite:

ZendTest\Validator\File\IsCompressedTest and ZendTest\Validator\File\IsImageTest have wrong PHP_VERSION comparison operators hence they throw errors in custom php 5.3.10 distributions, like 5.3.10-1ubuntu3.7 (stable on Ubuntu 12.04LTS) 

I have a PR ready to submit, give me instructions please :)


2013/7/22 Matthew Weier O'Phinney <[hidden email]>
Hey, all --

We've got only one PR left marked for 2.2.2, and I've asked the
Community Review team for review of that. At this point, I'd like
folks to test what's on current master against their applications, and
let me know ASAP if you notice anything that does not work.

I plan to tag and release no later than Wednesday.

Thanks everyone for the great patches this past month!

--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc


Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

weierophinney
Administrator
On Wed, Jul 24, 2013 at 6:58 AM, Martin Keckeis
<[hidden email]> wrote:
> @Marco thanks, yes with "run-tests.php" it work....
>
> But there are others problem then so i stopped them for now...maybe i'll do
> a UnitTest compability day for windows....
>
> All path tests for example are problematic due to slash/backslash and so
> on....

That's a long-standing myth. PHP is actually really good at ensuring
the paths passed to the underlying OS are properly formatted; I've not
seen any evidence to the contrary for many years.


> 2013/7/24 Stefano Torresi <[hidden email]>
>>
>> It's not framework related but rather about the test suite:
>>
>> ZendTest\Validator\File\IsCompressedTest and
>> ZendTest\Validator\File\IsImageTest have wrong PHP_VERSION comparison
>> operators hence they throw errors in custom php 5.3.10 distributions, like
>> 5.3.10-1ubuntu3.7 (stable on Ubuntu 12.04LTS)
>>
>> I have a PR ready to submit, give me instructions please :)
>>
>>
>> 2013/7/22 Matthew Weier O'Phinney <[hidden email]>
>>>
>>> Hey, all --
>>>
>>> We've got only one PR left marked for 2.2.2, and I've asked the
>>> Community Review team for review of that. At this point, I'd like
>>> folks to test what's on current master against their applications, and
>>> let me know ASAP if you notice anything that does not work.
>>>
>>> I plan to tag and release no later than Wednesday.
>>>
>>> Thanks everyone for the great patches this past month!
>>>
>>> --
>>> Matthew Weier O'Phinney
>>> Project Lead            | [hidden email]
>>> Zend Framework          | http://framework.zend.com/
>>> PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
>>
>>
>



--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

weierophinney
Administrator
In reply to this post by Stefano Torresi
On Wed, Jul 24, 2013 at 5:31 AM, Stefano Torresi
<[hidden email]> wrote:
> It's not framework related but rather about the test suite:
>
> ZendTest\Validator\File\IsCompressedTest and
> ZendTest\Validator\File\IsImageTest have wrong PHP_VERSION comparison
> operators hence they throw errors in custom php 5.3.10 distributions, like
> 5.3.10-1ubuntu3.7 (stable on Ubuntu 12.04LTS)
>
> I have a PR ready to submit, give me instructions please :)

The CONTRIBUTING.md and README-GIT.md files contain information on how
to create and submit pull requests.

Can you elaborate on the above? I run ubuntu myself, though not with
the PHP from the distro, and tests have always run fine on all
versions of PHP 5.3 (as well as 5.4, and now 5.5). I regularly test
with 5.3.3 and 5.3.<latest> -- as does Travis-CI...


> 2013/7/22 Matthew Weier O'Phinney <[hidden email]>
>>
>> Hey, all --
>>
>> We've got only one PR left marked for 2.2.2, and I've asked the
>> Community Review team for review of that. At this point, I'd like
>> folks to test what's on current master against their applications, and
>> let me know ASAP if you notice anything that does not work.
>>
>> I plan to tag and release no later than Wednesday.
>>
>> Thanks everyone for the great patches this past month!
>>
>> --
>> Matthew Weier O'Phinney
>> Project Lead            | [hidden email]
>> Zend Framework          | http://framework.zend.com/
>> PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
>
>



--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

Ben Scholzen 'DASPRiD'
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

Stefano Torresi
In reply to this post by weierophinney
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

ThaDafinser
In reply to this post by weierophinney

2013/7/24 Matthew Weier O'Phinney <[hidden email]>
On Wed, Jul 24, 2013 at 6:58 AM, Martin Keckeis
<[hidden email]> wrote:
> @Marco thanks, yes with "run-tests.php" it work....
>
> But there are others problem then so i stopped them for now...maybe i'll do
> a UnitTest compability day for windows....
>
> All path tests for example are problematic due to slash/backslash and so
> on....

That's a long-standing myth. PHP is actually really good at ensuring
the paths passed to the underlying OS are properly formatted; I've not
seen any evidence to the contrary for many years.


You are generally right....but if it's implemented "wrong" than it won't work.

Take this example:
2) ZendTest\Cache\Pattern\CaptureCacheTest::testGetFilenameWithoutPublicDirAndNo
PageId
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/dir1/test.html'
+'\dir1\test.html' 

Currently:
$this->assertEquals('/dir1/test', $captureCache->getFilename('/dir1/test'));
Right would/could be (here without a general function):
$this->assertEquals(DIRECTORY_SEPARATOR . 'dir1' . DIRECTORY_SEPARATOR . 'test', $captureCache->getFilename('/dir1/test'));


Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

weierophinney
Administrator
On Wed, Jul 24, 2013 at 9:22 AM, Martin Keckeis
<[hidden email]> wrote:

>
> 2013/7/24 Matthew Weier O'Phinney <[hidden email]>
>>
>> On Wed, Jul 24, 2013 at 6:58 AM, Martin Keckeis
>> <[hidden email]> wrote:
>> > @Marco thanks, yes with "run-tests.php" it work....
>> >
>> > But there are others problem then so i stopped them for now...maybe i'll
>> > do
>> > a UnitTest compability day for windows....
>> >
>> > All path tests for example are problematic due to slash/backslash and so
>> > on....
>>
>> That's a long-standing myth. PHP is actually really good at ensuring
>> the paths passed to the underlying OS are properly formatted; I've not
>> seen any evidence to the contrary for many years.
>>
>
> You are generally right....but if it's implemented "wrong" than it won't
> work.
>
> Take this example:
> 2)
> ZendTest\Cache\Pattern\CaptureCacheTest::testGetFilenameWithoutPublicDirAndNo
> PageId
> Failed asserting that two strings are equal.
> --- Expected
> +++ Actual
> @@ @@
> -'/dir1/test.html'
> +'\dir1\test.html'
>
> Currently:
> $this->assertEquals('/dir1/test', $captureCache->getFilename('/dir1/test'));
> Right would/could be (here without a general function):
> $this->assertEquals(DIRECTORY_SEPARATOR . 'dir1' . DIRECTORY_SEPARATOR .
> 'test', $captureCache->getFilename('/dir1/test'));

Aha -- makes sense!

So, yes... feel free to contribute patches to this that will make the
tests run cross-platform!


--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

weierophinney
Administrator
In reply to this post by Stefano Torresi
On Wed, Jul 24, 2013 at 9:18 AM, Stefano Torresi
<[hidden email]> wrote:
> Sorry I wasn't very clear, I know how to submit the PR, but I wanted to know
> if I can just do that normally after you called the code freeze :)
>
> The problem is much simpler than you think. I'll just submit the PR and
> elaborate there ;)
>
> https://github.com/zendframework/zf2/pull/4877

BTW, PRs are always welcome -- when I announce a freeze, it simply
means we won't be merging any more PRs for the stated release unless
testing shows they are warranted.

Thanks for this!

> 2013/7/24 Matthew Weier O'Phinney <[hidden email]>
>>
>>
>> The CONTRIBUTING.md and README-GIT.md files contain information on how
>> to create and submit pull requests.
>>
>> Can you elaborate on the above? I run ubuntu myself, though not with
>> the PHP from the distro, and tests have always run fine on all
>> versions of PHP 5.3 (as well as 5.4, and now 5.5). I regularly test
>> with 5.3.3 and 5.3.<latest> -- as does Travis-CI...
>>
>



--
Matthew Weier O'Phinney
Project Lead            | [hidden email]
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

Tomáš Fejfar
In reply to this post by ThaDafinser
Matthew, PHP is really good in ensuring that the path can be understood by the underlying system, but it does not do the same for string comparison. 

Other option is to have some helper function 

path($path) {return strtr($path, '/', DIRECTORY_SEPARATOR);} 

and use it in tests like 

$this->assertEquals(path('/dir1/test'), $captureCache->getFilename('/dir1/test'));

Tomas Fejfar 
tomasfejfar.cz



On Wed, Jul 24, 2013 at 4:22 PM, Martin Keckeis <[hidden email]> wrote:

2013/7/24 Matthew Weier O'Phinney <[hidden email]>
On Wed, Jul 24, 2013 at 6:58 AM, Martin Keckeis
<[hidden email]> wrote:
> @Marco thanks, yes with "run-tests.php" it work....
>
> But there are others problem then so i stopped them for now...maybe i'll do
> a UnitTest compability day for windows....
>
> All path tests for example are problematic due to slash/backslash and so
> on....

That's a long-standing myth. PHP is actually really good at ensuring
the paths passed to the underlying OS are properly formatted; I've not
seen any evidence to the contrary for many years.


You are generally right....but if it's implemented "wrong" than it won't work.

Take this example:
2) ZendTest\Cache\Pattern\CaptureCacheTest::testGetFilenameWithoutPublicDirAndNo
PageId
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/dir1/test.html'
+'\dir1\test.html' 

Currently:
$this->assertEquals('/dir1/test', $captureCache->getFilename('/dir1/test'));
Right would/could be (here without a general function):
$this->assertEquals(DIRECTORY_SEPARATOR . 'dir1' . DIRECTORY_SEPARATOR . 'test', $captureCache->getFilename('/dir1/test'));



Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

ThaDafinser
Hello together,

just recogniced maybe a bug or BC break....

The translator behaviour between 2.2.1/2.2.2 changed. (just downloaded freshly both tags)

How i use translator:
config.php
    'translator' => array(
        'locale' => 'en_US',
        'translation_file_patterns' => array(
            array(
                'type' => 'gettext',
                'base_dir' => __DIR__ . '/../../../data/language',
                'pattern' => '%s.mo'
            )
        )
    ),

Module.php Service
'translator' => function  (ServiceManager $serviceManager)
                {
                    $translator = Translator::factory($serviceManager->get('config')['translator']);
                    // $cache = new \Zend\Cache\Storage\Adapter\Apc(array(
                    // 'namespace' => 'myTranslation'
                    // ));
                    // $translator->setCache($cache);
                    
                    return $translator;
                },

I one module in the method onBootstrap i change the language/locale based on the user settings. (if logged in)

    public function onBootstrap (EventInterface $event)
    {
                //....some code and then user locale (here faked)
                $serviceManager->get('translator')->setLocale('de_AT');
    }

When i translate now a message in the controller -> everything is fine and gets translated to the set user locale "de_AT".

But the VIEW uses the settings from the configuration...so the default locale/language "en_US" will be used....


Any one else seeing this behaviour?
Seems that the service is around twice...will try to debug it later....



2013/7/24 Tomáš Fejfar <[hidden email]>
Matthew, PHP is really good in ensuring that the path can be understood by the underlying system, but it does not do the same for string comparison. 

Other option is to have some helper function 

path($path) {return strtr($path, '/', DIRECTORY_SEPARATOR);} 

and use it in tests like 

$this->assertEquals(path('/dir1/test'), $captureCache->getFilename('/dir1/test'));

Tomas Fejfar 
tomasfejfar.cz



On Wed, Jul 24, 2013 at 4:22 PM, Martin Keckeis <[hidden email]> wrote:

2013/7/24 Matthew Weier O'Phinney <[hidden email]>
On Wed, Jul 24, 2013 at 6:58 AM, Martin Keckeis
<[hidden email]> wrote:
> @Marco thanks, yes with "run-tests.php" it work....
>
> But there are others problem then so i stopped them for now...maybe i'll do
> a UnitTest compability day for windows....
>
> All path tests for example are problematic due to slash/backslash and so
> on....

That's a long-standing myth. PHP is actually really good at ensuring
the paths passed to the underlying OS are properly formatted; I've not
seen any evidence to the contrary for many years.


You are generally right....but if it's implemented "wrong" than it won't work.

Take this example:
2) ZendTest\Cache\Pattern\CaptureCacheTest::testGetFilenameWithoutPublicDirAndNo
PageId
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/dir1/test.html'
+'\dir1\test.html' 

Currently:
$this->assertEquals('/dir1/test', $captureCache->getFilename('/dir1/test'));
Right would/could be (here without a general function):
$this->assertEquals(DIRECTORY_SEPARATOR . 'dir1' . DIRECTORY_SEPARATOR . 'test', $captureCache->getFilename('/dir1/test'));




Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

ThaDafinser
Sorry that i didn't recogniced it yesterday, but my user setting was en_US, so i didn't saw any difference :-)
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

ThaDafinser
Hello,

found the problem...i think it's related to this: https://github.com/zendframework/zf2/pull/4870

Two services are now around and used: mvctranslator + translator...
mvcTranslator is used in view
translator is used in controller

If setting this two - everything is fine
$serviceManager->get('mvcTranslator')->setLocale('en_US');

but it seems to be a BC break...
Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

ThaDafinser
Hello,

i'm not the only one with this problem, see here: https://github.com/zendframework/zf2/issues/4910

Is there any advice for this?


2013/7/25 Martin Keckeis <[hidden email]>
Hello,

found the problem...i think it's related to this: https://github.com/zendframework/zf2/pull/4870

Two services are now around and used: mvctranslator + translator...
mvcTranslator is used in view
translator is used in controller

If setting this two - everything is fine
$serviceManager->get('mvcTranslator')->setLocale('en_US');

but it seems to be a BC break...

Reply | Threaded
Open this post in threaded view
|

Re: Code freeze for 2.2.2

Matus Zeman
Hi,
it looks like this is still an issue with subforms from  v2.2? https://github.com/zendframework/zf2/pull/4383
I'm not sure if somebody else can confirm the same... how can I generate form with input names without any prefix (for parent form) and all subforms with element names like "subform_111[element_aaa]", "subform_111[element_bbb]", "subform_222[element_aaa]" etc?

Cheers,
Matus


On 31 July 2013 13:18, Martin Keckeis <[hidden email]> wrote:
Hello,

i'm not the only one with this problem, see here: https://github.com/zendframework/zf2/issues/4910

Is there any advice for this?


2013/7/25 Martin Keckeis <[hidden email]>
Hello,

found the problem...i think it's related to this: https://github.com/zendframework/zf2/pull/4870

Two services are now around and used: mvctranslator + translator...
mvcTranslator is used in view
translator is used in controller

If setting this two - everything is fine
$serviceManager->get('mvcTranslator')->setLocale('en_US');

but it seems to be a BC break...